Page 1 of 1

Junk protection

PostPosted: Thu Feb 27, 2020 10:42 am
by Gorka
I accidentally junked my spear of pestilence today, after noticing a wooden spear in inv, and typing "junk spear."

Thanks to Maniac I got it back, but I got to thinking how I can protect against it happening again. Some people just don't junk things. Well, that's not really practical... if you run areas like EU where most of the mobs are astrals, and all the items drop to the ground and you have to use "get all" to sift through them. Dropping them instead of junking them only leads to massive piles of crap at the mob for the next pop, and the game performance is effected by the amount of objects in memory after a while. Here is how you can code around it with mudlet...

Pattern: ^junk(.+)$
Proc:

if matches[2] == " spear" then
echo("DO NOT JUNK!!")
elseif matches[2] == " winter" then
echo("DO NOT JUNK!!")
elseif matches[2] == " hell" then
echo("DO NOT JUNK!!")
elseif matches[2] == " blade" then
echo("DO NOT JUNK!!")
elseif matches[2] == " sword" then
echo("DO NOT JUNK!!")
elseif matches[2] == " souls" then
echo("DO NOT JUNK!!")
elseif matches[2] == " elite" then
echo("DO NOT JUNK!!")
elseif matches[2] == " sphairai" then
echo("DO NOT JUNK!!")
else
send("junk"..matches[2])
end

Now this is fairly light protection... theoretically you could grab matches[2], then "names" it to get the full item name... ie, names matches[2] then match it against a list of items names you aren't allowed to junk, or store the names of your items in a database table. That would be the ultimate protection. However those items which you usually have in inv, like weapons, keychains, flux etc you could protect quickly with this approach.

Ideally the game wouldn't allow you to junk PERSONAL items, or items with a rune/clasp attached... forcing you to abandon them on the ground or drop them at the dump to get rid of them.

Re: Junk protection

PostPosted: Thu Feb 27, 2020 11:50 pm
by Filk
Ideally, there should be standart confirmation question after junking personal item

Re: Junk protection

PostPosted: Fri Feb 28, 2020 1:10 pm
by Bandit
Maybe a "junk!" command for personal items? Just like some other things require the ! as a confirmation of something that can't be reversed.

Re: Junk protection

PostPosted: Mon Mar 02, 2020 4:07 pm
by *teker*
So thinking along these lines, would it also make sense to protect against:
- drop
- give
- sell

What items should be protected?
- personal
- items with clasps/runes
- items in eqsets
- containers with any of the above items inside

Re: Junk protection

PostPosted: Tue Mar 03, 2020 3:36 am
by Gorka
*teker* wrote:So thinking along these lines, would it also make sense to protect against:
- drop
- give
- sell

What items should be protected?
- personal
- items with clasps/runes
- items in eqsets
- containers with any of the above items inside


Not sure about protecting against, drop, give and sell... and these options don't destroy the item anyway, so they are less harmful. How else would one drop the bag of merchandise from quickling king for example, while trying to load a haste book. Would need to allow giving personal items anyway for quests. Sell is already blocked if I recall correctly, unless it's a drachma item. So I'd suggest nothing here.

>What items should be protected?
- personal - YES
- items with clasps/runes - YES
- items in eqsets - Hmm, bare in mind some items you don't want to junk aren't in eq sets.
- containers with any of the above items inside - Already can't junk containers with items inside.

Just stopping the junking of items with clasps / runes or personal items would go 95% of the way. Not sure the other 5% (eqset items) is worth the work and most valuable eqset items would be covered with runes or clasps anyway. The benefit is, once coded, imms don't have to be involved with reimbursement which must be a bit of a nuisance.

Implementing a confirmation to junk for certain items, isn't a bad idea, but seems a lot of work for little benefit.

Re: Junk protection

PostPosted: Tue Mar 03, 2020 2:24 pm
by *teker*
Gorka wrote:Not sure about protecting against, drop, give and sell... and these options don't destroy the item anyway, so they are less harmful. How else would one drop the bag of merchandise from quickling king for example, while trying to load a haste book.


I'm thinking we'd implement drop!, give!, sell!, etc just like junk! that would bypass protection (if protection is desired).

Re: Junk protection

PostPosted: Wed Mar 04, 2020 3:41 pm
by *Breeze*
Good idea teker

Re: Junk protection

PostPosted: Wed Apr 01, 2020 11:14 am
by *teker*
Version 1 of this feature went live with the reboot yesterday. Help IPROTECT.

Re: Junk protection

PostPosted: Wed Apr 01, 2020 12:53 pm
by Gorka
>IPROTECT
ILIKEIT Teker!

I wondered if the immortals and builders might consider adding a blank no effects clasp to the game which attaches to anything, so that we might be able to attach it to things like our drinking containers and key chains to protect those also. There maybe other solutions to this problem through item personalization (may create exploits though), or through cursing them, or options in eqset, but the clasp idea... if it were possible to attach this to anything, it would allow us to protect any item of subjective importance, not just what is deemed valuable. Also another thing to cycle... and probably very easy to create and zone as a clasp in the game.

Re: Junk protection

PostPosted: Wed Sep 15, 2021 1:28 am
by cnl
good news.

the clasps in Kings Bazaar are very non discriminating about what you attach them to (except the fruit one). put some on my flask of fury and a gold sack.

iprotect works very well.